-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storysource: Fix import error #25391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works for storysource as the underlying `./dist/preset.js` is still in CJS
ndelangen
approved these changes
Jan 3, 2024
ndelangen
changed the title
fix: import error for storysource
Storysource: Fix import error
Jan 3, 2024
shilman
added
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Jan 8, 2024
storybook-bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
This was referenced Jan 8, 2024
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
25 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
storybook-bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
Storysource: Fix import error (cherry picked from commit be9c746)
github-actions
bot
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Jan 12, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
addon: storysource
bug
ci:normal
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a specific case of #23972 for
@storybook/addon-storysource
.What I did
This works for storysource as the underlying
./dist/preset.js
is still in CJS.In general, there are a few issues:
type: module
in theirpackage.json
.{addon}/manager.js
and{addon}/preview.js
are meant for CJS consumption (as ESM will use the info in theexports
field in thepackage.json
). So they should be in CJS format. However, that means the code they reference should also in CJS which most of them are not (except for storysource's preset).That means a better fix is adding the
type: module
and removing the{addon}/manager.js
and{addon}/preview.js
files.I can create another PR for that (which needs more testing).
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>